It’s pretty clear that there are two basic kinds of developers; those that write code only to get the job done, and those that write code which in addition to getting the job done also looks good. I’m definitely part of the latter group and I have to say that sometimes I get frustrated when working with developers of the former conviction.
I was just reviewing some code written in a project I haven’t been involved in much, and found a set of very commonly used classes that lie in a namespace that is misspelled. I realize this doesn’t matter. I mean, the code does exactly what it’s supposed to do and the misspelling is so simple that everyone understands what it was meant to be called. But c’mon! Correcting the mistake would take about 2 minutes thanks to the refactoring functionality in Visual Studio.
Now to the difficult question… Should I mention it in my review?